[Bug 731722] OpenGL: Add an element for transforming video geometry

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731722
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Matthew Waters <ystreet00 at gmail.com> 2014-06-17 12:42:59 UTC ---
Review of attachment 278540:
 --> (https://bugzilla.gnome.org/review?bug=731722&attachment=278540)

I think it would be better to cache the transformation matrix and only
recompute when some value changes instead of each frame?

Otherwise, just a couple of little things on top of Mathieu's comments.

Good job :)

::: ext/gl/gstgltransformation.c
@@ +140,3 @@
+  // Rotation
+  g_object_class_install_property (gobject_class, PROP_XROTATION,
+      g_param_spec_float ("xrotation", "X Rotation",

Name should be "rotation-x".  Same for all the other property names

@@ +430,3 @@
+  gl->Disable (GL_TEXTURE_2D);
+
+  gl->Enable (GL_DEPTH_TEST);

This doesn't need the depth test.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.