[Bug 731722] OpenGL: Add an element for transforming video geometry

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731722
  GStreamer | gst-plugins-bad | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278599|none                        |reviewed
             status|                            |

--- Comment #5 from Matthew Waters <ystreet00 at gmail.com> 2014-06-17 13:35:48 UTC ---
Review of attachment 278599:
 --> (https://bugzilla.gnome.org/review?bug=731722&attachment=278599)

Very close :)

::: ext/gl/gstgltransformation.c
@@ +32,3 @@
+ * gst-launch gltestsrc ! gltransformation xtranslate=4 ! video/x-raw,
width=640, height=480 ! glimagesink
+ * ]| Resize scene after drawing.
+ * The scene size is greater than the input video size.

(Actually the pipeline is negotiated such that gltestsrc produces full-frame
640x480 buffers)

@@ +36,3 @@
+ * gst-launch gltestsrc ! video/x-raw, width=1280, height=720 !
gltransformation xscale=1.5 ! glimagesink
+ * ]| Resize scene before drawing the cube.
+ * The scene size is greater than the input video size.

copy-paste error?

@@ +66,3 @@
+
+#define DEBUG_INIT \
+    GST_DEBUG_CATEGORY_INIT (gst_gl_transformation_debug, "GLTransformation",
0, "GLTransformation element");

Debug categories are generally lowercase for elements

@@ +92,3 @@
+    "#ifdef GL_ES                                 \n"
+    "  precision mediump float;                   \n"
+    "#endif                                       \n"

The precision qualifiers are only needed in the fragment stage, not the vertex
stage.

::: ext/gl/gstgltransformation.h
@@ +75,3 @@
+G_END_DECLS
+
+#endif /* _GST_GLTransformation_H_ */

nitpick.  All CAPS - _GST_GL_TRANSFORMATION_H_

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.