[Bug 731791] videometa: add GstVideoAffineTransformationMeta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731791
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278612|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-17 16:55:35 UTC ---
Review of attachment 278612:
 --> (https://bugzilla.gnome.org/review?bug=731791&attachment=278612)

How is it negotiated? Are users of this API expected to handle all possible
transformations? What's the expected behaviour for transformations that convert
a rectangular video to a non-rectangular one (or non multiple of 90°
rotations)?

::: gst-libs/gst/video/gstvideoaffinetransformationmeta.h
@@ +46,3 @@
+ * gst_video_affine_transformation_meta_get_matrix.
+ * The user can provide its own get_matrix function, which can be used to
+ * retrieve a transformation matrix from the buffer.

Define if this is matrix is stored by rows or by columns, and maybe use a
[4][4] array instead?

@@ +57,3 @@
+
+  gfloat matrix[16];
+  GstVideoAffineTransformationGetMatrix get_matrix;

Why the get_matrix function pointer? What is this supposed to do other than
returning the matrix?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.