[Bug 731204] androidmedia: Implement zerocopy rendering

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jun 18 07:28:37 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=731204
  GStreamer | gst-plugins-bad | git

--- Comment #19 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-06-18 14:28:29 UTC ---
(From update of attachment 278417)
>               profile =
>-                  gst_amc_mpeg4_profile_to_string (type->
>-                  profile_levels[j].profile);
>+                  gst_amc_mpeg4_profile_to_string (type->profile_levels[j].
>+                  profile);

These kind of lines GNU indent will often "ping pong" between different styles,
even with the same version. Ideally rewrite the code to avoid such constructs
if the end up going over the end of the line (at column 80). Maybe save the
lookup into a local variable or so.

>-  is_eos = ! !(buffer_info.flags & BUFFER_FLAG_END_OF_STREAM);
>+  is_eos = !!(buffer_info.flags & BUFFER_FLAG_END_OF_STREAM);

This is '!!' in old GNU indent versions and '!  !' in newer ones. Please don't
change it back to the old formatting. Ideally upgrade.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list