[Bug 731716] funnel: fix eos handling and unit test case

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jun 18 16:05:58 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=731716
  GStreamer | gstreamer (core) | 1.2.4

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-06-18 23:05:53 UTC ---
It would be nice if your commit message actually explained what you fixed/what
changed, or how the current behaviour wasn't right (easier for reviewers to
match that to what the patch does). It seems to me one might want different
modes for funnel: one where it forwards the first EOS, and one where it only
forwards EOS once it's see EOS on all input pads. Either seems equally
plausible IMHO, unless you envision the element is only used on once specific
use case.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list