[Bug 731892] gstvalue: Avoid expensive g_type_check_value_holds calls when dealing with fundamental GType

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jun 18 22:56:06 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=731892
  GStreamer | gstreamer (core) | unspecified

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> 2014-06-19 05:56:02 UTC ---
Created an attachment (id=278731)
 View: https://bugzilla.gnome.org/attachment.cgi?id=278731
 Review: https://bugzilla.gnome.org/review?bug=731892&attachment=278731

gstvalue: Check GValue type directly for fundamentals

When wanting to check whether a GValue is of a certain fundamental
type, we can just check directly the GValue type instead of doing
a more expensive G_VALUE_HOLDS (which calls g_type_check_value_holds())

Benchmark:
 * valgrind callgrind (instruction calls):
 gst_value_compare: 48% to 58% of the calls (70 to 100% speedup)
 gst_value_subtract: 62% to 79% of the calls (27 to 60% speedup)
 gst_value_intersect: 51% to 60% of the calls (66 to 94% speedup)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list