[Bug 731892] gstvalue: Avoid expensive g_type_check_value_holds calls when dealing with fundamental GType

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jun 20 03:27:34 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=731892
  GStreamer | gstreamer (core) | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.3.3

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-06-20 10:27:29 UTC ---
I think this is obsolete now:

commit 6880844d8a9a0d4cd1703e5d197ee3ae2cc20819
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue Jun 17 22:45:57 2014 +0100

    value: simplify GST_VALUE_HOLDS for our boxed and fundamental types

    Boxed types can't be derived from, and we don't support
    deriving from our special fundamental types (the code
    checks for GType equality in most places.

commit bc75a166f01d7e75b0990f17b9f85fad9ad8585f
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Jun 19 08:09:55 2014 +0100

    gstvalue: optimise checks for lists

    Our fundamental types are non-derivable, so we can
    just check for equality. Also avoid doing the same
    check multiple times in a couple of places.

(sorry for the duplicate work, but I had been working on that already, just
hadn't pushed it yet because of the unit tests needing fixing for the compiler
warning)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list