[Bug 725828] hlsdemux: reporting playlist and fragment download time stat

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jun 23 04:00:37 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=725828
  GStreamer | gst-plugins-bad | 1.x

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-06-23 11:00:36 UTC ---
Gratuitous comments: I don't entirely see the value of the
gst_hls_demux_post_stat_msg() helper function, might just as well do it in the
code, doesn't save any lines really, does it (if you embed the
gst_structure_new() without assigning it to a variable)?

Regarding the names:

 - "hlsdemux-statistics" -> maybe "hls-statistics" ?
    Or maybe we want to make it generic for all these
    adaptive thingies from the start? Or does it not map?

 - "time-of-first-playlist" -> this time is absolute?
    why only for the first then?

 - "time-to-playlist" -> "playlist-download-time" ?

 - "time-to-download-fragment" -> "fragment-download-time" ?

(Don't know really, I have no strong opinions here, I think it's all fine.)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list