[Bug 732144] No Unit tests available for Videobox element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732144
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279082|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-24 08:09:11 UTC ---
Review of attachment 279082:
 --> (https://bugzilla.gnome.org/review?bug=732144&attachment=279082)

Thanks for the patch, good work :) Just some minor comments

::: tests/check/elements/videobox.c
@@ +151,3 @@
+    state_ret = gst_element_set_state (ctx.pipeline, GST_STATE_PAUSED);
+    fail_unless (state_ret != GST_STATE_CHANGE_FAILURE,
+        "couldn't set pipeline to PAUSED state");

This is racy... very unlikely but it could happen that you shutdown your
element already before it actually negotiates :)

Try setting num-buffers=1 on videotestsrc and then wait for the EOS message (or
an ERROR message) on the bus.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.