[Bug 732144] No Unit tests available for Videobox element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732144
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279103|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-24 10:56:40 UTC ---
Review of attachment 279103:
 --> (https://bugzilla.gnome.org/review?bug=732144&attachment=279103)

And some nitpicking

::: tests/check/Makefile.am
@@ +375,3 @@
     $(check_taglib) \
     $(check_udp) \
+        $(check_videobox) \

Indention is broken here

::: tests/check/elements/videobox.c
@@ +44,3 @@
+{
+  gchar in_caps[MAX_CAPS_LEN];
+  gchar out_caps[MAX_CAPS_LEN];

You can also make them const gchar *in_caps; etc. No need to fiddle with the
length here

@@ +52,3 @@
+ * Update this table as and when the conversion is supported(or unsupported)
in videobox
+ */
+static FormatConversion ConversionTable[] = {

We name variables lowercase and separated with _ usually, so conversion_table.
Also make this table const :)

@@ +170,3 @@
+  gst_object_unref (bus);
+
+  conversions_test_size = sizeof (ConversionTable) / sizeof
(FormatConversion);

G_N_ELEMENTS(ConversionTable)

@@ +224,3 @@
+  suite_add_tcase (s, tc_chain);
+  tcase_add_test (tc_chain, test_caps_transform);
+  /* FIXME: Add relevant test cases */

FIXME comment can go away

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.