[Bug 732203] h264parse: improve handling of byte-stream/au format

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732203
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Gwenole Beauchesne <gb.devel at gmail.com> 2014-06-25 11:58:52 UTC ---
(In reply to comment #4)
> Created an attachment (id=279218)
 View: https://bugzilla.gnome.org/attachment.cgi?id=279218
 Review: https://bugzilla.gnome.org/review?bug=732203&attachment=279218

> h264parse: improve conditions for skipping NAL unit
> 
> Carefully track cases when skipping broken or invalid NAL units is necessary.
> In particular, always allow NAL units to be processed and let that
> gst_h264_parse_process_nal() function decide on whether the current NAL needs
> to be dropped or not.
> 
> This fixes parsing of streams with SEI NAL buffering_period() message inserted
> between SPS and PPS, or SPS-Ext NAL following a traditional SPS NAL unit, among
> other cases too.
> 
> Practical examples include from H.264 AVC conformance suite include
> alphaconformanceG, CVSE2_Sony_B, CVSE3_Sony_H, CVSEFDFT3_Sony_E when parsing in
> stream-format=byte-stream,alignment=au mode.

This also obsoletes patch for bug #731831. I am not too certain of that former
requirement to discard SEI messages available between SPS and PPS. They are
definitely allowed, at least for buffering_period() messages.

I could trivially update gst_h264_parse_process_sei() to return a boolean and
check for that if needed. i.e. only allow buffering_period() to appear anywhere
after an SPS, and disallow all other SEI messages between SPS and PPS.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.