[Bug 732227] tsdemux: Leaks memory of section data

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jun 25 05:16:48 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=732227
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bilboed at bilboed.com

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> 2014-06-25 12:16:44 UTC ---
I went through the code again, and the only place that could have leaked
something was this:

commit cddabd751c760454915bcd3a485f241939499292
Author: Edward Hervey <bilboed at bilboed.com>
Date:   Wed Jun 25 14:13:55 2014 +0200

    mpegtssection: Free data in error cases

    Data is marked as "transfer full", if we have an error we need to
    free it.

diff --git a/gst-libs/gst/mpegts/gstmpegtssection.c
b/gst-libs/gst/mpegts/gstmpegtssection.c
index 5167a39..7f000c4 100644
--- a/gst-libs/gst/mpegts/gstmpegtssection.c
+++ b/gst-libs/gst/mpegts/gstmpegtssection.c
@@ -1223,6 +1223,7 @@ short_packet:
     GST_WARNING
         ("PID 0x%04x section extends past provided data (got:%" G_GSIZE_FORMAT
         ", need:%d)", pid, data_size, section_length + 3);
+    g_free (data);
     return NULL;
   }
 }

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list