[Bug 731474] playbin stalls when trying to play the audio portion of a stream with flags="audio"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731474
  GStreamer | gstreamer (core) | git

--- Comment #12 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-06-25 13:12:11 UTC ---
(In reply to comment #11)
> (In reply to comment #9)
> > It would make baseparse accumulate data in this scenario. And when it receives
> > a buffer with a ts=X it would be pushing data downstream that would be before
> > X. 
> > I'd prefer to have the parser drop everything before returning upstream to
> > prevent this scenario as upstream can handle buffering and not-linked returns
> > better.
> 
> I don't understand what you mean :) What I meant is that we should not pass any
> further data to baseparse and directly return not-linked and other errors
> (instead of continuing to pass the remaining data).

Imagine that baseparse gets a buffer that contains 1+N frames and it tries to
push 1 but it gets not-linked. It returns the not-linked upstream but it will
have N frames remaining in its adapter. If this repeats over the next buffers
received it will go accumulating N, 2N, 3N, 4N... frames in its adapter. As
baseparse is not a buffering element it will never limit its adapter size.

This is the main reason for me to think that returning not-linked immediately
is not a good idea. Continue pushing data downstream seem to be what we do for
other elements that are not buffering or have only a single sink and source
pads.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.