[Bug 731769] add element implementing the ONVIF RTP extension

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731769
  GStreamer | gst-plugins-bad | unspecified

--- Comment #6 from Guillaume Desmottes <gdesmott at gnome.org> 2014-06-26 14:02:19 UTC ---
(In reply to comment #4)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > ::: gst/onvif/gstonviftimestamp-apply.c
> > > @@ +212,3 @@
> > > +    gst_event_copy_segment (event, &self->segment);
> > > +  } else if (GST_EVENT_TYPE (event) == GST_EVENT_FLUSH_START) {
> > > +    gst_segment_init (&self->segment, GST_FORMAT_UNDEFINED);
> > > 
> > > This should probably happen on flush stop (as in this case, the stream lock is
> > > held).
> > 
> > You mean that gst_segment_init() should be called for both events? FLUSH_START
> > and FLUSH_STOP?
> 
> I think only on flush_stop, as the stream lock is not held during flush-start,
> so I think it could race with the segment event.

Ok; I changed that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.