[Bug 707282] Memory leak in h264 codecparser

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707282
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279365|none                        |accepted-commit_now
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-27 09:19:20 UTC ---
Review of attachment 279365:
 --> (https://bugzilla.gnome.org/review?bug=707282&attachment=279365)

Please push, but before fix these small things :)

::: gst-libs/gst/codecparsers/gsth264parser.c
@@ +227,3 @@
+ */
+static gboolean
+gst_h264_pps_copy (GstH264PPS * dst_pps, const GstH264PPS * src_pps)

The src_pps should be const probably

@@ +239,3 @@
+    dst_pps->slice_group_id = g_memdup (src_pps->slice_group_id,
+        src_pps->pic_size_in_map_units_minus1 + 1);
+    if (!dst_pps->slice_group_id)

g_memdup() will abort() if it fails to allocate memory

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.