[Bug 732445] aggregator: Many invalid memory access to destroyed GSources in the unit test

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732445
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279587|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-30 10:35:34 UTC ---
Review of attachment 279587:
 --> (https://bugzilla.gnome.org/review?bug=732445&attachment=279587)

::: gst-libs/gst/base/gstaggregator.c
@@ +382,3 @@
+_destroy_gsource (GSource * source)
+{
+  g_source_destroy (source);

Don't you additionally have to unref the source? Otherwise looks good

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.