[Bug 725104] qtdemux: reverse playback and video stream switching failure

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725104
  GStreamer | gst-plugins-good | 1.2.3

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.2.4
         OS/Version|Linux                       |All

--- Comment #19 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-03-03 17:28:31 UTC ---
Pushed both fixes to 1.2. I'm marking this as fixed now.

commit 19a01df528a743e2d5d41e69ed73957c97cd507b
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Sat Mar 1 01:14:35 2014 -0300

    qtdemux: prevent segfault after seeking with negative rate

    After a seek, the position and segments info of qtdemux are
    reset to null or invalid values. For reverse playback, qtdemux
    will seek to a keyframe and play until the next keyframe, then
    seek to another previous keyframe. This seeking function requires
    the position and segments info of qtdemux to be properly initialized.

    Due to a missing check for segment.rate in the movie demuxing loop
    it would consider the current segment to have ended without having
    it initialized, leading qtdemux to attempt to do a previous keyframe
    seek without proper position and segment info data. This would cause
     a segfault. This patch fixes it by correctly checking for segment
    boundaries taking the segment.rate into consideration.

    https://bugzilla.gnome.org/show_bug.cgi?id=725104

commit 5c2a239f6685f6feef75b9af38e5f80bf761b678
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Thu Feb 27 18:55:04 2014 -0300

    jpegdec: mark all parsed frames as sync points

    all jpeg frames are sync points, so mark them as such so
    reverse playback can properly work with the video decoder
    base class

    https://bugzilla.gnome.org/show_bug.cgi?id=725104

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.