[Bug 725632] v4l2: Normalise control names in the same way as v4l2-ctl
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Mar 8 16:18:00 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=725632
GStreamer | gst-plugins-good | 1.2.3
Nicolas Dufresne <nicolas.dufresne> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #13 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-09 00:40:57 UTC ---
Thanks
commit 4f47442c7f467a970e139871560af0ed4cb33ea0
Author: William Manley <will at williammanley.net>
Date: Sat Mar 8 19:29:58 2014 -0500
v4l2: Fix typo contol -> control
https://bugzilla.gnome.org/show_bug.cgi?id=725632
commit d3bd3ecc3ebadf5f4871a34b9c268b1ac791cf06
Author: William Manley <will at williammanley.net>
Date: Tue Mar 4 01:15:49 2014 +0000
v4l2: Normalise control names in the same way as v4l2-ctl
V4L2 kernel drivers allow configuration of the hardware settings via a
mechanism called controls. These can be referred to by name such as
"Brightness" and "White Balance Temperature". The user-space command line
client for setting these controls (v4l2-ctl) normalises these names such
that they only contain lower case alphanumeric characters and the
underscore '_'. e.g:
Kernel v4l2-ctl
----------------------------------------------------
Brightness brightness
White Balance Temperature white_balance_temperature
Focus (absolute) focus_absolute
GStreamer seems to want to follow this pattern but failed for controls with
more than one consecutive non-alphanum character. e.g. GStreamer would
produce "focus__absolute_" rather than "focus_absolute".
This commit fixes that issue. Backwards compatibility is preserved by
normalising all control names before comparison.
https://bugzilla.gnome.org/show_bug.cgi?id=725632
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the gstreamer-bugs
mailing list