[Bug 725632] v4l2: Normalise control names in the same way as v4l2-ctl

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725632
  GStreamer | gst-plugins-good | 1.2.3

--- Comment #22 from Will Manley <gnome at williammanley.net> 2014-03-10 16:53:44 UTC ---
Created an attachment (id=271448)
 View: https://bugzilla.gnome.org/attachment.cgi?id=271448
 Review: https://bugzilla.gnome.org/review?bug=725632&attachment=271448

Patch against master making backwards compatibilty less liberal

(In reply to comment #20)
> (From update of attachment 271257 [details])
> We need to avoid marking obsolete patches marked commited. I personnally didn't
> care if it was slightly less restrictive then before, though it might be a
> concern for 1.2. I consider this as tempory code tha we'll remove, so doing
> more work on it is not that productive.

Sorry for the confusion.  I should have said earlier that I was working on
another version of the patch so as to not waste your time.  I've attached a
patch which can be applied against master to get the same effect as reverting
d3bd3ec and applying the newer version of the patch.  As you say this is
temporary and the reason I think the newer version of the patch is better is
precisely because it is easier to remove in the future.

Commit message follows which I hope will make things clearer:

    v4l2: Make backwards compatibility code stricter

    d3bd3ec fixed an inconsistency in v4l2 control name normalisation
    between GStreamer and v4l2-ctl.  This included backwards compatibility
    code which means that applications which rely on the old normalisation
    scheme to continue working.  e.g. for the control "Exposure, Auto" both
    the new "exposure_auto" and the old "exposure__auto" will be accepted.

    Unfortunately the way this was implemented means that the code will now
    accept a *much* wider range of control names.  e.g. "exposure___auto",
    "__ExPoSuRe-_-AUto__" will both now be accepted (albiet with a warning).
    In the interests of making it easier to remove this backward
    compatibility hack in the future this patch narrows the acceptable names
    to just the old deprecated ones and the new ones.

    This patch also tidies the backwards compatibilty code up a bit making it
    more self-contained, easier to remove and better documented.  Backwards
    compatibility will disable itself in 1.5 (using preprocessor macros) and
    can then be removed.

    This is perhaps better considerred a fixup to d3bd3ec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.