[Bug 726104] Proposal for a v4l2scale element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726104
  GStreamer | gst-plugins-good | 1.2.3

--- Comment #4 from Andreea Fulger <andreea.fulger at parrot.com> 2014-03-12 08:59:08 UTC ---
Review of attachment 271520:
 --> (https://bugzilla.gnome.org/review?bug=726104&attachment=271520)

::: sys/v4l2/gstv4l2scale.c
@@ +536,3 @@
+
+  LOG_CAPS (v4l2scale, incaps);
+  LOG_CAPS (v4l2scale, outcaps);

No, there is no particular reason for having these logs. I guess they where
useful when debugging.

@@ +539,3 @@
+
+  sinkObj = v4l2scale->v4l2sinkobject;
+  srcObj = v4l2scale->v4l2srcobject;

Ok, I will update my code.

@@ +589,3 @@
+
+static gboolean
+gst_v4l2scale_decide_allocation (GstBaseTransform * trans, GstQuery * query)

What do you mean by "generalized"? And why should I see propose_allocation?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.