[Bug 726337] omxbufferpool: leak buffers when stopped

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726337
  GStreamer | gst-omx | git

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-03-14 17:10:28 UTC ---
Review of attachment 271881:
 --> (https://bugzilla.gnome.org/review?bug=726337&attachment=271881)

::: omx/gstomxbufferpool.c
@@ +220,3 @@

+  g_ptr_array_foreach (pool->buffers,
+      gst_omx_buffer_pool_free_buffer_foreach_func, bpool);

any reason to not do it here, would save quite a few lines:

for (i = 0; i < pool->buffers->len; i++)
  gst_omx_buffer_pool_free_buffer (pool, g_ptr_array_index (buffers,i));

Otherwise it looks good to me too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.