[Bug 726329] [vp8enc] Add support for caps renegotiation

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Mar 15 04:25:31 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=726329
  GStreamer | gst-plugins-good | 1.x

--- Comment #6 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-15 11:49:30 UTC ---
(In reply to comment #5)
> It was my first idea, but then I realized that the lock should be released to
> call gst_video_encoder_finish_frame this could end in race conditions during
> the caps renegotiation. If you think that is better not to change to recursive
> mutex I can rework it, but I think that the risk of race conditions will be
> there.

Well no, you hare holding the pads stream lock already in the function (it's a
chain handler). That lock is only there to protect against a property change.
hence a fast mutex is preferred. I would remove that lock and use the object if
it as me doing the patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list