[Bug 723652] missing documentation of GST_PAD_SET_PROXY_CAPS

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723652
  GStreamer | documentation | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271985|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-15 11:56:39 UTC ---
Review of attachment 271985:
 --> (https://bugzilla.gnome.org/review?bug=723652&attachment=271985)

Looks good mostly, thanks for the patch :)

::: gst/gstpad.h
@@ +755,3 @@
+ * @pad: a #GstPad
+ *
+ * Get parent element.

It's not necesarily an element, it could also be another pad or something
completely different. Also mention that no locking happens here

@@ +801,3 @@
+ *
+ * Get the @pad activation function (#GstPadActivateFunction).
+ * This function is called when the pad is activated during the element

Instead of explaining all these functions here I think you can just link to the
docs of the GstPadActivateFunction and the others

@@ +875,3 @@
+ * @pad: a #GstPad
+ *
+ * Return the pad's peer memeber. This memeber is a pointer to the linked
@pad.

Typo (memeber) and mention that no locking happens here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.