[Bug 720031] omxh264enc key frame interval missing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720031
  GStreamer | gst-omx | 1.2.1

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271652|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-15 12:26:41 UTC ---
Review of attachment 271652:
 --> (https://bugzilla.gnome.org/review?bug=720031&attachment=271652)

::: gst-omx_old/omx/gstomxh264enc.c
@@ +59,3 @@
+/**< reference: OMX_CONFIG_PORTBOOLEANTYPE*/
+#define OMX_IndexParamBrcmVideoAVCInlineHeaderEnable  0x7f0000df
+#define OMX_IndexParamBrcmPixelAspectRatio        0x7f00004d

Isn't this defined by OMX_Broadcom.h?

@@ +208,3 @@
+                                          &config_inline_header);
+  if (err != OMX_ErrorNone) {
+    GST_ERROR_OBJECT (self, "can't get
OMX_IndexParamBrcmVideoAVCInlineHeaderEnable %s (0x%08x)",
gst_omx_error_to_string (err), err);

Please run all this through gst-indent :)

@@ +311,3 @@
     }
+
+    if (gst_structure_get_double(s, "level", &leveldouble)) {

"level" is always a string field, not an integer or double.

@@ +312,3 @@
+
+    if (gst_structure_get_double(s, "level", &leveldouble)) {
+      level_string = g_strdup_printf("%0.1lf", leveldouble);

Please put this into a separate commit

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.