[Bug 726376] x265enc: Add x265 encoder element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726376
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271949|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-16 19:08:15 UTC ---
Review of attachment 271949:
 --> (https://bugzilla.gnome.org/review?bug=726376&attachment=271949)

Thanks for the patch :) Just a very short review for now

::: configure.ac
@@ +818,3 @@
   IGraphBuilder *pGraph = NULL;
   HRESULT hr = CoInitialize(NULL);
+  hr = CoCreateInstance(&CLSID_FilterGraph, NULL, CLSCTX_INPROC_SERVER,

Please remove all these whitespace changes from the diff :)

::: ext/x265/gstx265enc.c
@@ +171,3 @@
+        "width = (int) [ 4, MAX ], " "height = (int) [ 4, MAX ], "
+        "stream-format = (string) { avc, byte-stream }, "
+        "alignment = (string) au, " "profile = (string) { main }")

The stream formats are hvc1, hev1 and byte-stream. And the caps have profile,
level and tier which need to be negotiated.

@@ +487,3 @@
+gst_x265_enc_start (GstVideoEncoder * encoder)
+{
+  //GstX265Enc *x265enc = GST_X265_ENC (encoder);

No C99 comments please

::: ext/x265/gstx265enc.h
@@ +74,3 @@
+  const gchar *peer_profile;
+  gboolean peer_intra_profile;
+  /*const x265_level_t *peer_level; */

You should probably have the profile, level and tier here and negotiate them

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.