[Bug 726472] rtpbasepayload: Implement video SDP attributes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726472
  GStreamer | gst-plugins-base | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272085|none                        |needs-work
             status|                            |

--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-03-16 19:15:46 UTC ---
Review of attachment 272085:
 --> (https://bugzilla.gnome.org/review?bug=726472&attachment=272085)

::: gst-libs/gst/rtp/gstrtpbasepayload.c
@@ +416,3 @@
+    g_value_init (&value, G_TYPE_DOUBLE);
+    g_value_set_double (&value, framerate);
+    gst_structure_set_value (payload->priv->video_attributes, "a-framerate",

I think like all other SDP attributes, it should be string.

@@ +455,3 @@
+      s = gst_caps_get_structure (caps, 0);
+      if (g_str_has_prefix (gst_structure_get_name (s), "video")) {
+        parse_video_attributes (rtpbasepayload, s);

Any reason to check for video here? I'd just push a-framerate for any time
which has "framerate" or "max-framerate" in the caps. You can also just get it
from the current caps in set_outcaps?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.