[Bug 726337] omxbufferpool: leak buffers when stopped

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726337
  GStreamer | gst-omx | git

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271881|0                           |1
        is obsolete|                            |

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> 2014-03-17 10:03:30 UTC ---
Created an attachment (id=272127)
 View: https://bugzilla.gnome.org/attachment.cgi?id=272127
 Review: https://bugzilla.gnome.org/review?bug=726337&attachment=272127

omxbufferpool: fix memory leak if used on output port

(In reply to comment #2)
> Review of attachment 271881 [details]:
> 
> ::: omx/gstomxbufferpool.c
> @@ +220,3 @@
> 
> +  g_ptr_array_foreach (pool->buffers,
> +      gst_omx_buffer_pool_free_buffer_foreach_func, bpool);
> 
> any reason to not do it here, would save quite a few lines:
> 
> for (i = 0; i < pool->buffers->len; i++)
>   gst_omx_buffer_pool_free_buffer (pool, g_ptr_array_index (buffers,i));
> 
> Otherwise it looks good to me too.

No particular reason, and I prefer your suggestion :) Thx

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.