[Bug 726494] use wglCreateContextAttribsARB to create share context

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726494
  GStreamer | gst-plugins-gl | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272121|none                        |needs-work
             status|                            |

--- Comment #1 from Matthew Waters <ystreet00 at gmail.com> 2014-03-17 10:34:08 UTC ---
Review of attachment 272121:
 --> (https://bugzilla.gnome.org/review?bug=726494&attachment=272121)

Otherwise, looks good.

::: gst-libs/gst/gl/win32/gstglcontext_wgl.c
@@ +133,3 @@
+
+    if (wglCreateContextAttribsARB == NULL) {
+      g_set_error (error, GST_GL_CONTEXT_ERROR,

It would be better to fallback to wglShareLists rather than failing/

--- Comment #2 from Matthew Waters <ystreet00 at gmail.com> 2014-03-17 10:34:09 UTC ---
Review of attachment 272121:
 --> (https://bugzilla.gnome.org/review?bug=726494&attachment=272121)

Otherwise, looks good.

::: gst-libs/gst/gl/win32/gstglcontext_wgl.c
@@ +133,3 @@
+
+    if (wglCreateContextAttribsARB == NULL) {
+      g_set_error (error, GST_GL_CONTEXT_ERROR,

It would be better to fallback to wglShareLists rather than failing/

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.