[Bug 725175] Decklinksrc segfaults on Linux Mint 16

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725175
  GStreamer | gst-plugins-bad | git

Isaac Smith <isaac> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Isaac Smith <isaac at isrv.pw> 2014-03-17 16:51:45 UTC ---
Fixed! Not sure what exactly was wrong, for some reason Blackmagic's driver
didn't like how the config interface was retrieved, I changed the code to
reflect the method specified in the manual. Patch below, what's t

diff --git a/sys/decklink/gstdecklinksrc.cpp b/sys/decklink/gstdecklinksrc.cpp
index 7c2683a..2e4bdea 100644
--- a/sys/decklink/gstdecklinksrc.cpp
+++ b/sys/decklink/gstdecklinksrc.cpp
@@ -416,6 +416,8 @@ gst_decklink_src_start (GstElement * element)
   BMDVideoConnection conn;
   BMDAudioConnection aconn;

+  int64_t currentVideoInputConnection;
+
   GST_DEBUG_OBJECT (decklinksrc, "start");

   decklinksrc->decklink = gst_decklink_get_nth_device
(decklinksrc->device_number);
@@ -433,7 +435,7 @@ gst_decklink_src_start (GstElement * element)
     return FALSE;
   }

-  decklinksrc->config = gst_decklink_get_nth_config
(decklinksrc->device_number);
+  decklinksrc->decklink->QueryInterface (IID_IDeckLinkConfiguration,
(void**)&decklinksrc->config);
   config = decklinksrc->config;

   switch (decklinksrc->connection) {
@@ -463,7 +465,8 @@ gst_decklink_src_start (GstElement * element)
       aconn = bmdAudioConnectionAnalog;
       break;
   }
-
+  config->GetInt (bmdDeckLinkConfigVideoInputConnection,
&currentVideoInputConnection);
+  GST_DEBUG ("current video connection: %i",
int(currentVideoInputConnection));
   ret = config->SetInt (bmdDeckLinkConfigVideoInputConnection, conn);
   if (ret != S_OK) {
     GST_ERROR ("set configuration (input source)");

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.