[Bug 726325] RFC: Add tunneling support.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726325
  GStreamer | gst-omx | git

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271861|none                        |rejected
             status|                            |

--- Comment #13 from Julien Isorce <julien.isorce at gmail.com> 2014-03-18 10:10:30 UTC ---
Review of attachment 271861:
 --> (https://bugzilla.gnome.org/review?bug=726325&attachment=271861)

It's used with 1- OMX_UseEGLImage or 2- OMX_UseBuffer paths:

* 1- omxvideodec ! eglglessink and that's really important on Raspberry Pi
OMX.broadcom.egl_render / OMX_UseEGLImage / EGLImage
http://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n729
http://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n754

In this case the GstEGLImageBufferPool proposed by the videosink is decided by
GstVideoDecoder. Then omxvideodec set a GstOMXBufferPool on the output port of
the omx decoder. This later pool steals buffer from the GstEGLImageBufferPool.
We need to do that because we do not choice which id of omx buffer we get
filled on new frames. Whereas in default GstBufferPool implementation this a
queue so that is necessary circular.

* 2- omxvideodec ! ximagesink
OMX_UseBuffer / XShmCreateImage
http://cgit.collabora.com/git/user/julien/gst-omx.git/tree/omx/gstomxvideodec.c?h=resize#n1721
http://cgit.collabora.com/git/user/julien/gst-omx.git/tree/omx/gstomxvideodec.c?h=resize#n1743

Same as previous except the downstream buffer pool is the GstXImageBufferPool


So case 2 shows that we still need that for every gstomx elements.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.