[Bug 675132] tsdemux: implement proper seeking with binary search and keyframe detection

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Mar 19 16:02:18 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=675132
  GStreamer | gst-plugins-bad | git

--- Comment #14 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-03-19 23:26:53 UTC ---
Hi, here is an implementation compliant with Edward's remarks, as it's
integrated in the codepath. It's been tested with gst-validate and a
significant set of sample files, and all the bugs we encountered are fixed with
it.

It obviously makes seeking a little slower, as there now needs to be some
decoding done between the keyframe and the actual frame, but that delay is only
marginally introduced by the scanning, and mostly comes from the decoding,
which is inevitable if one wants to do things correctly and not get artefacts.

Additionally, the case where a seek is requested and there's no keyframe before
it (can happen with broken samples that I can provide) is correctly accounted
for.

The exact process for seeking is described in the commit message.

In the case of interlaced samples, an additional fix is needed in codecparsers,
which didn't set a framerate, the bug report is here :
https://bugzilla.gnome.org/show_bug.cgi?id=726752 .

What do you think folks ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list