[Bug 685890] codecparsers: h264: fix rbsp_more_data() implementation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=685890
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Gwenole Beauchesne <gb.devel at gmail.com> 2014-03-21 13:21:57 UTC ---
Looking at this one with another angle. The spec says that more_rbsp_data()
should look for the *last* bit set to 1, which corresponds to the
rbsp_stop_one_bit. So a loop is needed.

In order to be sure that we parsed the last one bit, this reduces to (i) we
parsed one bit set to 1 and (ii) all the remaining bits are set to zero. So, at
the end of the day, we can conclude to more_rbsp_data() == FALSE if get_bit()
== 1 and all remaining bits == 0. Thus implying more_rbsp_data() == TRUE if
get_bit() == 0 or if remaining bits are not zero.

So, this is what I had implemented actually, but failed to properly document
that. :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.