[Bug 726329] vp8enc: Add support for caps renegotiation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726329
  GStreamer | gst-plugins-good | 1.x

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272123|none                        |reviewed
             status|                            |

--- Comment #11 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-21 19:54:36 UTC ---
Review of attachment 272123:
 --> (https://bugzilla.gnome.org/review?bug=726329&attachment=272123)

::: ext/vpx/gstvp8enc.c
@@ +1516,3 @@
+    g_mutex_lock (&encoder->encoder_lock);
+    vpx_codec_destroy (&encoder->encoder);
+    encoder->inited = FALSE;

Normally I rename _finish() into _drain() (removing the lock), and implement
_finish() that simply lock and call _drain(). Then I can use _drain() whenever
needed. Let me know if you still have time, otherwise I can do that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.