[Bug 685215] codecparsers: h264: Add initial MVC parser

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Mar 24 06:28:48 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=685215
  GStreamer | gst-plugins-bad | git

--- Comment #28 from Gwenole Beauchesne <gb.devel at gmail.com> 2014-03-24 13:54:04 UTC ---
Review of attachment 238381:
 --> (https://bugzilla.gnome.org/review?bug=685215&attachment=238381)

Fixed locally. Several issues in there. BTW, it would be interesting to list
any sample that exhibit this SEI message. Thanks. :)

BTW, this patch is non-essential for the whole MVC codecparser series.

::: gst-libs/gst/codecparsers/gsth264parser.c
@@ +1210,3 @@
+  READ_UINT8 (nr, info->next_frame_is_second_view_flag, 1);
+  READ_UINT8 (nr, info->left_view_self_contained_flag, 1);
+  READ_UINT8 (nr, info->right_view_self_contained_flag, 1);

Missed field_views_flag condition for top_field_is_left_view_flag,
current_frame_is_left_view_flag, next_frame_is_second_view_flag.

Besides, using the _unchecked variant is possible and desirable.

::: gst-libs/gst/codecparsers/gsth264parser.h
@@ +875,3 @@
     GstH264BufferingPeriod buffering_period;
     GstH264PicTiming pic_timing;
+    GstH264StereoVideoInfo stereo_info;

stereo_video_info to match H.264 spec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list