[Bug 727100] v4l2bufferpool: Race condition on qbuf/dqbuf in a multithreaded context

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727100
  GStreamer | gst-plugins-good | 1.2.3

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273006|none                        |reviewed
             status|                            |

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-26 17:56:03 UTC ---
Review of attachment 273006:
 --> (https://bugzilla.gnome.org/review?bug=727100&attachment=273006)

::: sys/v4l2/gstv4l2bufferpool.h
@@ +61,3 @@
   guint num_queued;          /* number of buffers queued in the driver */
   guint copy_threshold;      /* when our pool runs lower, start handing out
copies */
+  GMutex mutex;

Only details, the object lock is unused, maybe you could use
GST_OBJECT_LOCK/UNLOCK instead of creating a new mutex ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.