[Bug 729333] orc: Add some checks on the number of variables per type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729333
  GStreamer | orc | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275547|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-01 15:32:19 UTC ---
Review of attachment 275547:
 --> (https://bugzilla.gnome.org/review?bug=729333&attachment=275547)

::: orc/orccompiler.c
@@ +194,3 @@
   ORC_INFO("initializing compiler for program \"%s\"", program->name);
+  error_msg = orc_program_get_error (program);
+  if (error_msg && strcmp (error_msg, "")) {

It should never be "", right?

::: orc/orcprogram.c
@@ +1049,3 @@
+  if (program->error_msg) {
+    free (program->error_msg);
+    program->error_msg = NULL;

Not sure this makes sense, you ideally always want to see the first error...
not the last

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.