[Bug 729333] orc: Add some checks on the number of variables per type

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu May 1 08:59:16 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=729333
  GStreamer | orc | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275552|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-01 15:59:13 UTC ---
Review of attachment 275552:
 --> (https://bugzilla.gnome.org/review?bug=729333&attachment=275552)

Shouldn't it return NULL instead of ""?

::: orc/orcprogram.c
@@ +1049,3 @@
+  if (!program->error_msg && error) {
+    program->error_msg = strdup (error);
+  }

Or maybe we can ensure that we never ever get multiple errors? Or that we
accumulate and output them all?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list