[Bug 729382] Add a name property to GESTimelineElement

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729382
  GStreamer | gst-editing-services | unspecified

--- Comment #19 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-05-02 12:58:42 UTC ---
Review of attachment 275638:
 --> (https://bugzilla.gnome.org/review?bug=729382&attachment=275638)

The name of the commit is a bit off I think, it's rather about adding an
action. Not OK

::: tools/ges-validate.c
@@ +60,3 @@
+  g_return_val_if_fail (GES_IS_TRACK_ELEMENT (element), FALSE);
+
+  property_name = gst_structure_get_string (action->structure, "property");

Same comment, mandatory blabla

@@ -123,2 +150,4 @@
         move_clip_mandatory_fields, "Allows to seek into the files", FALSE);

+    gst_validate_add_action_type ("set-child-property", _set_child_property,
+        move_clip_mandatory_fields,

move_clip_mandatory_fields ? shouldn't it be a new array ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.