[Bug 729196] omxvideodec: no memory:EGLImage feature in the caps when using eglimage allocator

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729196
  GStreamer | gst-omx | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275559|none                        |accepted-commit_now
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-02 14:35:34 UTC ---
Review of attachment 275559:
 --> (https://bugzilla.gnome.org/review?bug=729196&attachment=275559)

Don't be so impatient, other bugs are waiting weeks for a review :P (be part of
the solution :) )

Looks generally good but:

::: omx/gstomxvideodec.c
@@ +932,3 @@
+      state->caps = gst_video_info_to_caps (&state->info);
+      gst_caps_set_features (state->caps, 0,
+          gst_caps_features_new ("memory:EGLImage", NULL));

Don't we have a #define for that somewhere?

@@ +2417,3 @@
+      /* if try to negotiate with caps feature memory:EGLImage
+       * and if allocator is not of type memory EGLImage then fails */
+      if (feature && gst_caps_features_contains (feature, "memory:EGLImage")

and here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.