[Bug 729415] ges-validate: add actions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729415
  GStreamer | gst-editing-services | unspecified

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #275687|none                        |needs-work
             status|                            |

--- Comment #17 from Thibault Saunier <tsaunier at gnome.org> 2014-05-02 17:36:42 UTC ---
Review of attachment 275687:
 --> (https://bugzilla.gnome.org/review?bug=729415&attachment=275687)

That commit name is weird

::: tools/ges-validate.c
@@ +203,3 @@
+_remove_layer (GstValidateScenario *scenario, GstValidateAction *action)
+{
+  GESTimeline *timeline = get_timeline(scenario);

Have you double checked we do not get a ref? (I have a doubt)

@@ +235,3 @@
+  gboolean res = FALSE;
+
+  gst_structure_get_int(action->structure, "layer-priority", &layer_priority);

Hrm, why don't you get the layer from the clip directly? I think it would make
more sense

@@ +281,3 @@
+
+  if (!asset || error) {
+    GST_ERROR("There was an error requesting the asset with id %s and type
%s", asset_id, type_string);

You could print error->message, it is often useful :)

@@ +298,3 @@
+  }
+
+  clip = ges_layer_add_asset(layer, asset, -1, 0, duration,
GES_TRACK_TYPE_UNKNOWN);

duration = GST_CLOCK_TIME_NONE will do what you want.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.