[Bug 720596] discoverer: Rework the API to make "install missing plugin" feature cleaner

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720596
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266278|none                        |reviewed
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-03 07:56:42 UTC ---
Review of attachment 266278:
 --> (https://bugzilla.gnome.org/review?bug=720596&attachment=266278)

Looks good, just one remark. Please push afterwards :)

::: gst-libs/gst/pbutils/gstdiscoverer-types.c
@@ +1088,3 @@
+ * Returns: (transfer full): (array zero-terminated=1): An array of strings
+ * containing informations about how to install the various missing elements
+ * for @info to be usable. Free with g_strfreev.

Since: 1.4

@@ +1104,3 @@
+  }
+
+  ret = g_malloc0 (sizeof (gchar *) * info->missing_elements_details->len +
1);

I think for consistency it would be nice to return a const gchar ** here...
just append a NULL to the GPtrArray once discovering is done and then return
the pdata pointer directly.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.