[Bug 720597] decodebin: query allocation always sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720597
  GStreamer | gst-plugins-base | 1.2.1

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267143|none                        |reviewed
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-03 08:11:33 UTC ---
Review of attachment 267143:
 --> (https://bugzilla.gnome.org/review?bug=720597&attachment=267143)

::: gst-libs/gst/video/gstvideodecoder.c
@@ -3334,3 @@
-  decoder->priv->output_state_changed = FALSE;
-  /* Negotiate pool */
-  ret = gst_video_decoder_negotiate_pool (decoder, state->caps);

Note that negotiate_default calls negotiate_pool in some cases at the very very
top too. I think this can cause problems as you now unconditionally call
negotiate_pool *after* negotiate (_default)

@@ +3390,3 @@
+
+      state = gst_video_decoder_get_output_state (decoder);
+      ret = gst_video_decoder_negotiate_pool (decoder, state->caps);

Maybe pass the complete state here instead of just the caps? For future
extensibility

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.