[Bug 727802] md5 checksum is missing from flac files encoded with encodebin

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat May 3 07:49:45 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=727802
  GStreamer | gst-plugins-base | 1.2.3

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-03 14:49:38 UTC ---
Can be reproduced with
> ... ! flacenc ! flacparse ! filesink

Problem here is that flacparse claims to do the seeks for rewriting the headers
properly... but actually doesn't and also drops the data we send after seeking
(as they are incomplete flac frames, it's just the few bytes that need to be
rewritten).

So multiple problems here:
1) flacparse (and baseparse) should not claim to support seeking in BYTES
format if they actually don't completely (flacparse supports it, but only if
complete frames arrive
2) encodebin should not plug parsers unless required
3) Also that it plugs flactag here although not required is suspicious (but
flactag does not break anything here). encodebin should detect that flacenc can
do the tagging already

1) and 3) are more collateral problems, 2) is the real problem. Or one could
implement proper seeking there but that seems rather complicated and not too
useful.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list