[Bug 728501] rtpaux/rtprtx: Unit tests are racy and take very long sometimes

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun May 4 19:39:38 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=728501
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |olivier.crete at ocrete.ca
         Resolution|                            |FIXED
   Target Milestone|1.3.1                       |1.3.2

--- Comment #1 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-05-05 02:39:32 UTC ---
These should fix it! They're still horribly slow, but at least, much less racy.

commit 985897d8d95b13065ba19cb01aae105d2423feb2
Author: Olivier Crête <olivier.crete at ocrete.ca>
Date:   Sun May 4 20:23:29 2014 -0400

    rtpaux/rtprtx: Make tests non-racy

    Fix the raciness by iterating on a condition instead of using the
gmainloop.
    Don't use the EOS as the target, otherwise the retransmission of the last
    packets are lost. Also count the retranmissions requests that are dropped.
    Check the condition before blocking on the GCond

    https://bugzilla.gnome.org/show_bug.cgi?id=728501

commit b2a52035bf8a33c2b334a70e7a853e2a991248ae
Author: Olivier Crête <olivier.crete at ocrete.ca>
Date:   Sun May 4 22:32:54 2014 -0400

    rtprtxreceive: Wait until timeout to clear association requests

    If two streams request a retranmission for the same SSRC, ignore the second
    one if the first oen is less than one second old, otherwise time out the
first
    one and ignore the second.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list