[Bug 729617] playback-test: don't set negative values for buffer-size property on playbin

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729617
  GStreamer | gst-plugins-base | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-05-06 07:16:09 UTC ---
I don't think this patch is right. It doesn't fix the actual problem, and -1 is
a valid value for the buffer-size property.

commit e5b4e30baab2378e9bb63550b815ff923bf8c806
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue May 6 07:51:11 2014 +0100

    examples: playback-test: fix crashes when setting buffer-size

    playbin's buffer-size property takes a gint, not a gint64,
    so only pass the bits expected to the vararg function, or
    the terminator might not be found, leading to crashes, esp.
    with negative numbers.

    Spotted by Ravi Kiran K N <ravi.kiran at samsung.com>

    https://bugzilla.gnome.org/show_bug.cgi?id=729617

commit bb74096870a4b7cfbad3461c5b64c038e2d35150
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue May 6 07:50:16 2014 +0100

    examples: fix indentation of playback-test

commit a8396ce5dbdd50f1cfd9d1786196e0527205d7ce
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue May 6 08:13:24 2014 +0100

    Revert "playback-test: Set buffer-size only for non-negative size"

    This reverts commit 07a637e2847d56d0f2b0c0ac9095bf37dd324e26.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.