[Bug 728490] v4l2src: Missing unref in decide_allocation

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728490
  GStreamer | gst-plugins-good | 1.2.3

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274692|none                        |needs-work
             status|                            |

--- Comment #10 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-06 14:01:32 UTC ---
Review of attachment 274692:
 --> (https://bugzilla.gnome.org/review?bug=728490&attachment=274692)

Looks good, and matches what I already have in my branch.

::: sys/v4l2/gstv4l2src.c
@@ +509,3 @@
         GST_DEBUG_OBJECT (src,
             "read/write mode: no downstream pool, using our own");
+        pool = gst_object_ref (GST_BUFFER_POOL_CAST (obj->pool));

no need for the cast here, gst_object_ref() takes a gpointer for this reason

@@ +527,3 @@
+      if (pool)
+        gst_object_unref (pool);
+      pool = gst_object_ref (GST_BUFFER_POOL_CAST (obj->pool));

Same.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.