[Bug 729542] glimagesink: pool may never be activated, which leads to crash

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729542
  GStreamer | gst-plugins-bad | git

--- Comment #6 from Matthew Waters <ystreet00 at gmail.com> 2014-05-07 08:11:54 UTC ---
(In reply to comment #5)
> 1- There is no pool of textures in gst-launch-1.0 v4l2src ! glimagesink  ?

No

> 2- I guess we also need to apply this change in gstglfilter ? (gst-launch-1.0
> v4l2src ! gleffects ! glimagesink) 

No, the upload is created regardless of whether it is activated. 
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglfilter.c#n1116

> 3- Would it be better to start the gl buffer pool if not already active ?
> 
> if (G_UNLIKELY (!gst_buffer_pool_is_active (pool)) {
>   ret = gst_buffer_pool_set_active (pool);
>   if (!ret)
>     goto error;
> }

The extra textures are created/destroyed by GstGLUpload.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.