[Bug 727916] bufferpool: Does not implement set_config() as documented

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727916
  GStreamer | gstreamer (core) | git

--- Comment #9 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-07 17:51:39 UTC ---
Looking again, I notice that validating a config is more work then that. Since
we need to check that no option has been dropped.

If the only "generically" acceptable change is increasing min, or decreasing
max within min boundary, the right approach would be to keep a copy of the
config, and apply the min/max of the new config on the old one and set the
modified old one.

The dilemma I have, is that if the pool only makes "acceptable changes",
returning TRUE seems fair. Though, for libav setting max to min is not an
acceptable change. So I'm tempted to say that base classes can't really
validate anything.

So I'm starting to think that base class should presume modification by pool
are fine, and it's up to the class, through decide_allocation virtual to
validate these changes if they have specific rules.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.