[Bug 663944] souphttpsrc: leaking file descriptors + memory when destroyed while connecting

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=663944
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.3.2

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-08 08:19:57 UTC ---
And fixed in souphttpsrc too now, but only if a new enough libsoup is available
that contains the fix from bug #729737.

commit 2a7abc98dbd5a184dd83c57370c690436040fdec
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Thu May 8 09:49:24 2014 +0200

    souphttpsrc: Clean up all pending operations from libsoup before unreffing 

    When we cancel connection attempts and similar things, there are still
    some operations pending on our main context from the GCancellables. We
    should let them all run before unreffing our context, otherwise we leak
    file descriptors.

    Unfortunately this requires libsoup 2.47.0 or newer as earlier versions
    steal our main context from us and we can't use it for cleanup later
    without assertions and funny crashes.

    Based on a patch by Dmitry Shatrov <shatrov at gmail.com>.

    https://bugzilla.gnome.org/show_bug.cgi?id=663944

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.