[Bug 729882] opusenc: use aux vars to minimize critical region

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729882
  GStreamer | gst-plugins-bad | 1.2.4

--- Comment #3 from Miguel París Díaz <mparisdiaz at gmail.com> 2014-05-10 12:35:27 UTC ---
Review of attachment 276249:
 --> (https://bugzilla.gnome.org/review?bug=729882&attachment=276249)

::: ext/opus/gstopusenc.c
@@ +805,3 @@
+  n_channels = enc->n_channels;
+  frame_samples = enc->frame_samples;
+  state = enc->state;

About n_channels
  Its value is modified into a protected section:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/opus/gstopusenc.c?h=1.2#n613

About state with this change can be a problem because it can be destroyed
(http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/opus/gstopusenc.c?h=1.2#n621)
before use it
(http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/opus/gstopusenc.c?h=1.2#n834).

So I am going to do a change in this patch and upload it again.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.